✨ Add build digests to versions.json#300
Merged
Merged
Conversation
4e6bc5b to
1787532
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds build digest functionality to versions.json by modifying the workflow to capture Docker image digests during the build process and include them in the build metadata.
- Adds a new
digestfield to theBuildVersiondataclass - Implements
load_build_contextsfunction to read build metadata from JSON files - Updates CI workflow to store build digests and pass them to the release process
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/docker_python_nodejs/versions.py | Adds digest field to BuildVersion and implements load_build_contexts function |
| src/docker_python_nodejs/cli.py | Updates release command to use build contexts from files instead of generating versions |
| tests/test_all.py | Adds test coverage for the new load_build_contexts function |
| .github/workflows/build.yaml | Modifies workflow to capture and store build digests in artifacts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1787532 to
4554112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #222