a proposed fix to the strokeCap issue number #44 #45
Conversation
SiyabongaNzulwana
changed the title
|
I think this will break this use case: After applying your changes I see this:
You also have merge conflicts as I just merged #40 which ran prettier on the |
src/Pie.js
Outdated
| } | ||
|
|
||
| const Pie = ({ sections, radius, innerRadius, backgroundColor, strokeCap, dividerSize }) => { | ||
| strokeCapForLargeBands = dividerSize > 0 || strokeCap == 'butt' ? 'butt' : 'butt'; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yea, that ternary doesn't make much sense as it is right now, likely a typo
|
@SiyabongaNzulwana ready for review again? |
|
@zgordon01 Yes, its ready... |
|
This same line is currently causing our app to crash because the is no My guess is this repo is abandoned at this point, but hopeful! |
| strokeCap, | ||
| dividerSize, | ||
| }) => { | ||
| strokeCapForLargeBands = |
There was a problem hiding this comment.
Can we add const before establishing the variable?
|
@CarolynWebster Sorry I don't use RN for years, but if you can confirm this PR works, I'll update your propose directly and merge it |
4 participants
As I have mentioned that I was facing an issue with the
strokeCap={'round'}prop, I was able to figure out what the issue might be, and I decided to push a PR for the proposed fix. NB: this is happening on"version": "1.1.2".This is related to issue number #44