Improve OpenAPS reason display logic for AAPSClient #4452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - ProcessedDeviceStatusDataImpl: Show "Loop" label when enacted and suggested have matching reasons within 30s window - ProcessedDeviceStatusDataImpl: Show separate "Enacted"/"Suggested" labels only when reasons differ or enacted is stale This ensures consistent behavior across wear and phone interfaces, avoids showing duplicate or stale enacted data.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from: #4448
Problem
Duplicate "Enacted" and "Suggested" messages shown when they're the same
Stale enacted data in AAPSClient OpenAPS pill.
Solution
Show "Loop" label when enacted/suggested match
Hide stale enacted data
Testing
✅ TBR only
✅ SMB only
✅ TBR + SMB
✅ No changes loop
✅ Stale enacted data
Result: Cleaner, more accurate loop status display.
Some pictures to illustrate. See also: #3706
BEFORE
AFTER PR