Skip to content

Use PNPM and enforce js bundling in PR#151

Open
nick-fields wants to merge 11 commits intomasterfrom
nrf/pnpm
Open

Use PNPM and enforce js bundling in PR#151
nick-fields wants to merge 11 commits intomasterfrom
nrf/pnpm

Conversation

@nick-fields
Copy link
Owner

Description

  • Upgrade to pnpm because it's great
  • Handle scenario where contribution's made entirely in GH UI are bundled properly
    • If a contributor makes a change via the GH UI and opens a PR for it, pre-commit hooks are skipped
    • When the same change is made locally, a pre-commit hook fires to bundle the code change to ensure that the code changed matches the bundled code that GHA requires to be committed
    • To handle this, we now bundle on every commit and if changes exist, commit the bundle

Testing

  • No tests added, but the test will be if CI passes and the intentionally out of sync dist/index.js gets auto updated.

@xavier2k6
Copy link
Contributor

Why not use v4 of pnpm/action-setup?
https://github.com/pnpm/action-setup/releases

You could also look into increasing pnpm?
https://github.com/pnpm/pnpm/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants