Open
Conversation
Author
|
|
Author
|
I've made another attempt at this. My js isn't so good so bear with me! My understanding is that the test suite is ignoring the SIGTERM, here I propose escalating with a SIGINT, and then using SIGKILL to make sure that the retry of the command does not have the old one hanging around. Apart from addressing child process that ignore SIGTERM this would also address situations where the clean up is just too slow and a user does not wish to wait longer. I think my test is now better formulated to timeout at 5 mins so as not to waste CI resources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am working with a misbehaving test suite that hangs. "retry" has worked very nicely to avoid failures due to this hanging. One issue that I have noticed is that occasionally a pytest session fails to respond to the SIGTERM signal. When this happens two child processes run at the same time and make a bit of a mess. This PR proposes using SIGKILL to make sure the child process exits.
Testing