Skip to content

Fix step icon background#2907

Merged
rajsite merged 6 commits intomainfrom
step-bg
Mar 30, 2026
Merged

Fix step icon background#2907
rajsite merged 6 commits intomainfrom
step-bg

Conversation

@rajsite
Copy link
Copy Markdown
Member

@rajsite rajsite commented Mar 27, 2026

Pull Request

🤨 Rationale

Fixes two visual issues:

  • radial gradients used for the background image of the icon snaps to pixel boundaries and when you have odd scaling (like windows 150% zoom on high res displays) the background doesn't look centered and jitters as it resizes and snaps on pixel boundaries
  • border sizes are on pixel boundaries so you see a snapping behavior at the animation end
Screenshot_20260327-192908

stepper-before

👩‍💻 Implementation

To address:

  • Switched the icon background to a div with a bg color and radius that is transform sized
  • Switched the icon border to a box shadow where the sizes can scale continuously

stepper-after

🧪 Testing

Manual tests and chromatic results

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

rajsite added 4 commits March 18, 2026 17:34
Add a dedicated element for icon background that can scale its whole size and switch to box-shadow for smooth border size animations
@rajsite rajsite marked this pull request as ready for review March 27, 2026 21:04
@rajsite rajsite requested a review from jattasNI as a code owner March 27, 2026 21:04
@rajsite rajsite marked this pull request as draft March 27, 2026 21:10
@rajsite rajsite marked this pull request as ready for review March 27, 2026 22:29
@rajsite rajsite enabled auto-merge (squash) March 27, 2026 23:29
Copy link
Copy Markdown
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that both pinch zoom and the Zoom In menu look good on macOS Firefox and Safari

@rajsite rajsite merged commit 2e21c7f into main Mar 30, 2026
11 checks passed
@rajsite rajsite deleted the step-bg branch March 30, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants