Add base colors for the new variants of calendar events#2834
Merged
Conversation
vivinkrishna-ni
requested review from
fredvisser,
jattasNI and
rajsite
as code owners
jattasNI
approved these changes
Jan 29, 2026
…tps://github.com/ni/nimble into users/vivin/add-missing-base-colors-for-calendar
…tps://github.com/ni/nimble into users/vivin/add-missing-base-colors-for-calendar
Contributor
Author
|
@fredvisser @rajsite Kindly consider this as a gentle reminder to review the PR |
rajsite
approved these changes
Feb 10, 2026
rajsite
reviewed
Feb 10, 2026
rajsite
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
👩💻 Implementation
To create the calendar theme-aware tokens, we would need to add some of the missing base colors. The names of the colors are derived mostly from the visual design I linked above and are intended to be consistent with the other color names.
There will be a follow-up PR to create the calendar theme-aware tokens to add/update the tokens with the newly added base colors and the existing ones.
🧪 Testing
N/A
✅ Checklist