feat(http): expose upstream_states and request timing/byte accessors#291
Open
u5surf wants to merge 1 commit into
Open
feat(http): expose upstream_states and request timing/byte accessors#291u5surf wants to merge 1 commit into
u5surf wants to merge 1 commit into
Conversation
Add safe accessors for request struct fields that previously
required raw-pointer deref:
- `Request::upstream_states() -> &[UpstreamState]` walks each
upstream attempt (one per peer for `proxy_next_upstream`
retries) via a `#[repr(transparent)]` wrapper exposing
`peer`, `status`, `response_time`, `connect_time`,
`header_time`, `queue_time`, `bytes_sent`, `bytes_received`,
`response_length`.
- `Request::start_sec()`, `start_msec()`, `request_length()`,
`bytes_sent()` for the request-level timing/byte fields.
`Request::upstream()` (the raw-pointer accessor) is left untouched
to preserve compatibility.
Unit tests follow the `MaybeUninit::zeroed` pattern from nginx#272.
Signed-off-by: Y.Horie <u5.horie@gmail.com>
u5surf
force-pushed
the
feat/request-upstream-states-accessor
branch
from
2d4aceb to
0cec0b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add safe accessors for request struct fields that previously required raw-pointer deref:
Request::upstream_states() -> &[UpstreamState]walks each upstream attempt (one per peer forproxy_next_upstreamretries) via a#[repr(transparent)]wrapper exposingpeer,status,response_time,connect_time,header_time,queue_time,bytes_sent,bytes_received,response_length.Request::start_sec(),start_msec(),request_length(),bytes_sent()for the request-level timing/byte fields.Request::upstream()(the raw-pointer accessor) is left untouched to preserve compatibility.Unit tests follow the
MaybeUninit::zeroedpattern from #272.Checklist
Before creating a PR, run through this checklist and mark each as complete.