feat: expose stub_status connection-state atomics via event::connecti…#290
Open
u5surf wants to merge 1 commit into
Open
feat: expose stub_status connection-state atomics via event::connecti…#290u5surf wants to merge 1 commit into
u5surf wants to merge 1 commit into
Conversation
…on_stats Add a safe accessor for the seven `ngx_stat_*` globals nginx populates when built with `--with-http_stub_status_module`. Bindgen already emits the raw externs once that build flag is set, but consumers currently have to read them by hand with several `unsafe` casts; the new `event::connection_stats()` function returns a `ConnectionStats` snapshot in one call. Gated behind `#[cfg(ngx_feature = "stat_stub")]` so nginx builds without stub_status still link cleanly. Signed-off-by: Y.Horie <u5.horie@gmail.com>
u5surf
force-pushed
the
feat/expose-ngx-stat-stub
branch
from
5f74c2c to
39e7100
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on_stats
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue
on GitHub, make sure to include a link to that issue here in this description
(not in the title of the PR).
We would like to pure rust nginx status module, so we’d like to have a safe accessor for the seven
ngx_stat_*globals nginx populates when built with--with-http_stub_status_module.We can already emits the raw externs once that build flag is set, but we currently have to read them by hand with several
unsafecasts; the newevent::connection_stats()function returns aConnectionStatssnapshot in one call.Checklist
Before creating a PR, run through this checklist and mark each as complete.