Fix review comments 4.0.0#209
Conversation
The test profile is defined in the nf-test.config
vagkaratzas
left a comment
vagkaratzas
left a comment
There was a problem hiding this comment.
Minor things in general. Other than that, have a second look in the end-to-end pipeline tests/ . By sourcing the correct profile, you wouldnt need to do manual tweaks. Have a look at this.
Test files should be that simple.
|
The |
vagkaratzas
left a comment
vagkaratzas
left a comment
There was a problem hiding this comment.
Nice, the best tutorial is always other people's pipelines :D
Left a couple more comments to check before merging, but giving this the green light!
| when { | ||
| params { | ||
| outdir = "$outputDir" | ||
| outdir = "$outputDir" |
There was a problem hiding this comment.
can probably remove all this empty space now :D
| "pixelator/sample_2.pxl" | ||
| ], | ||
| [ | ||
|
|
There was a problem hiding this comment.
make sure nothing expected is missing from here
| def test_config = new ConfigSlurper().parse(new File("tests/nextflow.config").toURI().toURL()) | ||
| def pipelines_testdata_base_path = test_config.params.pipelines_testdata_base_path as String | ||
|
|
There was a problem hiding this comment.
Can safely remove these now as well
2 participants
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).