Skip to content

Conversation

@benjaminfrueh
Copy link
Contributor

Problem

When scrolling or zooming inside an embedded element, the wheel events would propagate to the parent, causing both the embed and the parent to zoom/pan simultaneously.

Solution

Attached wheel event listeners to each embed container that call stopPropagation() to prevent events propagating to the parent.

@benjaminfrueh benjaminfrueh added the bug Something isn't working label Dec 18, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Dec 18, 2025
@benjaminfrueh benjaminfrueh moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Office team Dec 18, 2025
Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>
@hweihwang hweihwang force-pushed the fix/embed-wheel-propagation branch from 1040c89 to d8d1586 Compare December 24, 2025 18:18
@juliusknorr juliusknorr merged commit 956e1dc into main Dec 30, 2025
31 checks passed
@juliusknorr juliusknorr deleted the fix/embed-wheel-propagation branch December 30, 2025 15:17
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

3 participants