Work towards RC1 #16
Open
Work towards RC1 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Signed-off-by: Sandro Mesterheide <sandro.mesterheide@extern.publicplan.de>
Signed-off-by: Sandro Mesterheide <sandro.mesterheide@extern.publicplan.de>
Signed-off-by: Sandro Mesterheide <sandro.mesterheide@extern.publicplan.de>
Signed-off-by: Sandro Mesterheide <sandro.mesterheide@extern.publicplan.de>
Signed-off-by: Sandro Mesterheide <sandro.mesterheide@extern.publicplan.de>
come-nc
reviewed
Mar 27, 2023
| "bamarni/composer-bin-plugin": true | ||
| }, | ||
| "platform": { | ||
| "php": "7.4" |
Contributor
There was a problem hiding this comment.
Put 8.0 or remove this block
| "bamarni/composer-bin-plugin": "^1.4", | ||
| "nextcloud/coding-standard": "^1.0.0", | ||
| "phpunit/phpunit": "^9.5", | ||
| "christophwurst/nextcloud": "dev-master", |
Contributor
There was a problem hiding this comment.
Should be replaced by nextcloud/ocp I think, for psalm to work.
| @@ -0,0 +1,189 @@ | |||
| <?php | |||
Comment on lines
+44
to
+60
| /** @var IL10N */ | ||
| private $l; | ||
|
|
||
| /** @var IURLGenerator */ | ||
| private $urlGenerator; | ||
|
|
||
| /** @var ICloudIdManager */ | ||
| private $cloudIdManager; | ||
|
|
||
| /** @var GroupBackend */ | ||
| private $voGroupBackend; | ||
|
|
||
| /** @var ProviderService */ | ||
| private $providerService; | ||
|
|
||
| /** @var IGroupManager */ | ||
| private $groupManager; |
Contributor
There was a problem hiding this comment.
Suggested change
| /** @var IL10N */ | |
| private $l; | |
| /** @var IURLGenerator */ | |
| private $urlGenerator; | |
| /** @var ICloudIdManager */ | |
| private $cloudIdManager; | |
| /** @var GroupBackend */ | |
| private $voGroupBackend; | |
| /** @var ProviderService */ | |
| private $providerService; | |
| /** @var IGroupManager */ | |
| private $groupManager; | |
| private IL10N $l; | |
| private IURLGenerator $urlGenerator; | |
| private ICloudIdManager $cloudIdManager; | |
| private GroupBackend $voGroupBackend; | |
| private ProviderService $providerService; | |
| private IGroupManager $groupManager; |
| * @return array [user, remoteURL] | ||
| * @throws HintException | ||
| */ | ||
| public function splitUserRemote($address) { |
Contributor
There was a problem hiding this comment.
Suggested change
| public function splitUserRemote($address) { | |
| public function splitUserRemote(string $address): array { |
| $qb = $this->dbConn->getQueryBuilder(); | ||
| $qb->delete('vo_groups') | ||
| ->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid))) | ||
| ->execute(); |
Contributor
There was a problem hiding this comment.
Suggested change
| ->execute(); | |
| ->executeStatement(); |
| $qb = $this->dbConn->getQueryBuilder(); | ||
| $qb->delete('vo_group_user') | ||
| ->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid))) | ||
| ->execute(); |
Contributor
There was a problem hiding this comment.
Suggested change
| ->execute(); | |
| ->executeStatement(); |
| $qb->insert('vo_group_user') | ||
| ->setValue('uid', $qb->createNamedParameter($uid)) | ||
| ->setValue('gid', $qb->createNamedParameter($gid)) | ||
| ->execute(); |
Contributor
There was a problem hiding this comment.
Suggested change
| ->execute(); | |
| ->executeStatement(); |
| ->from('vo_group_user') | ||
| ->where($qb->expr()->eq('gid', $qb->createNamedParameter($gid))) | ||
| ->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($uid))) | ||
| ->execute(); |
Contributor
There was a problem hiding this comment.
Suggested change
| ->execute(); | |
| ->executeQuery(); |
| @@ -0,0 +1,199 @@ | |||
| <?php | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.