Add option to show original image in viewer instead of showing a preview#3118
Open
david-brauer wants to merge 1 commit intonextcloud:masterfrom
Open
Add option to show original image in viewer instead of showing a preview#3118david-brauer wants to merge 1 commit intonextcloud:masterfrom
david-brauer wants to merge 1 commit intonextcloud:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to integrate a simple option to disable previews for images in the viewer. I'm still pretty new to nextcloud development and I don't really know VueJS. So this might not be up to some code standards. If you know a thing I can improve leave a comment and I will try to adapt it.
I know this topic has a very long discussion history with both sides actually having solid use cases for showing previews vs. showing original Images. As someone who only has Images that are 1-2 MB in size I never really had the urge for preview files and instead would like to see the full resolution image.
In my opinion the best solution for the issue is having a setting so that both sides can be happy.
With my change I added a setting that can be set via config.php to disable the previews in the viewer. The default case still remains the same so that previews are being displayed. Anyone that does want to view original images however can set the Option
disable_preview_in_viewerto true and get the original image shown.