refactor: Code optimizations

lib/Controller/ApiController.php

@@ -30,14 +30,6 @@ public function __construct(
 		parent::__construct(Application::APP_ID, $request);
 	}
 
-	/**
-	 * @param int $providerId
-	 * @param string $userId
-	 * @param string|null $displayName
-	 * @param string|null $email
-	 * @param string|null $quota
-	 * @return DataResponse
-	 */
 	#[NoCSRFRequired]
 	public function createUser(int $providerId, string $userId, ?string $displayName = null,
 		?string $email = null, ?string $quota = null): DataResponse {
@@ -59,25 +51,22 @@ public function createUser(int $providerId, string $userId, ?string $displayName
 			$user->setQuota($quota);
 		}
 
-		$userFolder = $this->root->getUserFolder($user->getUID());
+		$userId = $user->getUID();
+		$userFolder = $this->root->getUserFolder($userId);
 		try {
 			// copy skeleton
-			\OC_Util::copySkeleton($user->getUID(), $userFolder);
+			\OC_Util::copySkeleton($userId, $userFolder);
 		} catch (NotPermittedException $ex) {
 			// read only uses
 		}
 
-		return new DataResponse(['user_id' => $user->getUID()]);
+		return new DataResponse(['user_id' => $userId]);
 	}
 
-	/**
-	 * @param string $userId
-	 * @return DataResponse
-	 */
 	#[NoCSRFRequired]
 	public function deleteUser(string $userId): DataResponse {
 		$user = $this->userManager->get($userId);
-		if (is_null($user) || $user->getBackendClassName() !== Application::APP_ID) {
+		if ($user === null || $user->getBackendClassName() !== Application::APP_ID) {
 			return new DataResponse(['message' => 'User not found'], Http::STATUS_NOT_FOUND);
 		}
 

lib/Controller/BaseOidcController.php

@@ -26,60 +26,39 @@ public function __construct(
 		parent::__construct(Application::APP_ID, $request);
 	}
 
-	/**
-	 * @return bool
-	 */
 	protected function isDebugModeEnabled(): bool {
 		return $this->config->getSystemValueBool('debug', false);
 	}
 
-	/**
-	 * @param string $message
-	 * @param int $statusCode
-	 * @param array $throttleMetadata
-	 * @param bool|null $throttle
-	 * @return TemplateResponse
-	 */
-	protected function buildErrorTemplateResponse(string $message, int $statusCode, array $throttleMetadata = [], ?bool $throttle = null): TemplateResponse {
+	protected function buildErrorTemplateResponse(
+		string $message, int $statusCode, array $throttleMetadata = [], ?bool $throttle = null
+	): TemplateResponse {
 		$params = [
 			'message' => $message,
 			'title' => $this->l->t('Error'),
 		];
 		return $this->buildFailureTemplateResponse($params, $statusCode, $throttleMetadata, $throttle);
 	}
 
-	/**
-	 * @param string $message
-	 * @param int $statusCode
-	 * @param array $throttleMetadata
-	 * @param bool|null $throttle
-	 * @return TemplateResponse
-	 */
-	protected function build403TemplateResponse(string $message, int $statusCode, array $throttleMetadata = [], ?bool $throttle = null): TemplateResponse {
+	protected function build403TemplateResponse(string $message, int $statusCode, array $throttleMetadata = [],
+		?bool $throttle = null): TemplateResponse {
 		$params = [
 			'message' => $message,
 			'title' => $this->l->t('Access forbidden'),
 		];
 		return $this->buildFailureTemplateResponse($params, $statusCode, $throttleMetadata, $throttle);
 	}
 
-	/**
-	 * @param array $params
-	 * @param int $statusCode
-	 * @param array $throttleMetadata
-	 * @param bool|null $throttle
-	 * @return TemplateResponse
-	 */
-	protected function buildFailureTemplateResponse(
-		array $params, int $statusCode, array $throttleMetadata = [], ?bool $throttle = null,
-	): TemplateResponse {
+	protected function buildFailureTemplateResponse(array $params, int $statusCode, array $throttleMetadata = [],
+		?bool $throttle = null): TemplateResponse {
 		$response = new TemplateResponse(
 			Application::APP_ID,
 			'error',
 			$params,
 			TemplateResponse::RENDER_AS_ERROR
 		);
 		$response->setStatus($statusCode);
+
 		// if not specified, throttle if debug mode is off
 		if (($throttle === null && !$this->isDebugModeEnabled()) || $throttle) {
 			$response->throttle($throttleMetadata);
@@ -89,15 +68,8 @@ protected function buildFailureTemplateResponse(
 
 	// TODO: use the following methods only when 32 is the min supported version
 	// as it includes the "back to NC" button
-
-	/**
-	 * @param string $message
-	 * @param int $statusCode
-	 * @param array $throttleMetadata
-	 * @param bool|null $throttle
-	 * @return TemplateResponse
-	 */
-	protected function buildCoreErrorTemplateResponse(string $message, int $statusCode, array $throttleMetadata = [], ?bool $throttle = null): TemplateResponse {
+	protected function buildCoreErrorTemplateResponse(string $message, int $statusCode, array $throttleMetadata = [],
+		?bool $throttle = null): TemplateResponse {
 		$params = [
 			'errors' => [
 				['error' => $message],
@@ -106,27 +78,12 @@ protected function buildCoreErrorTemplateResponse(string $message, int $statusCo
 		return $this->buildCoreFailureTemplateResponse('', 'error', $params, $statusCode, $throttleMetadata, $throttle);
 	}
 
-	/**
-	 * @param string $message
-	 * @param int $statusCode
-	 * @param array $throttleMetadata
-	 * @param bool|null $throttle
-	 * @return TemplateResponse
-	 */
-	protected function buildCore403TemplateResponse(string $message, int $statusCode, array $throttleMetadata = [], ?bool $throttle = null): TemplateResponse {
+	protected function buildCore403TemplateResponse(string $message, int $statusCode, array $throttleMetadata = [],
+		?bool $throttle = null): TemplateResponse {
 		$params = ['message' => $message];
 		return $this->buildCoreFailureTemplateResponse('core', '403', $params, $statusCode, $throttleMetadata, $throttle);
 	}
 
-	/**
-	 * @param string $appName
-	 * @param string $templateName
-	 * @param array $params
-	 * @param int $statusCode
-	 * @param array $throttleMetadata
-	 * @param bool|null $throttle
-	 * @return TemplateResponse
-	 */
 	protected function buildCoreFailureTemplateResponse(string $appName, string $templateName, array $params, int $statusCode,
 		array $throttleMetadata = [], ?bool $throttle = null): TemplateResponse {
 		$response = new TemplateResponse(
@@ -136,6 +93,7 @@ protected function buildCoreFailureTemplateResponse(string $appName, string $tem
 			TemplateResponse::RENDER_AS_ERROR
 		);
 		$response->setStatus($statusCode);
+
 		// if not specified, throttle if debug mode is off
 		if (($throttle === null && !$this->isDebugModeEnabled()) || $throttle) {
 			$response->throttle($throttleMetadata);

lib/Controller/Id4meController.php

@@ -55,33 +55,33 @@
 
 	public function __construct(
 		IRequest $request,
-		private ISecureRandom $random,
-		private ISession $session,
+		private readonly ISecureRandom $random,
+		private readonly ISession $session,
 		IConfig $config,
-		private IL10N $l10n,
-		private ITimeFactory $timeFactory,
-		private IClientService $clientService,
-		private IURLGenerator $urlGenerator,
-		private UserMapper $userMapper,
-		private IUserSession $userSession,
-		private IUserManager $userManager,
+		private readonly IL10N $l10n,
+		private readonly ITimeFactory $timeFactory,
+		private readonly IClientService $clientService,
+		private readonly IURLGenerator $urlGenerator,
+		private readonly UserMapper $userMapper,
+		private readonly IUserSession $userSession,
+		private readonly IUserManager $userManager,
 		HttpClientHelper $clientHelper,
-		private Id4MeMapper $id4MeMapper,
-		private ID4MeService $id4MeService,
-		private LoggerInterface $logger,
-		private ICrypto $crypto,
+		private readonly Id4MeMapper $id4MeMapper,
+		private readonly ID4MeService $id4MeService,
+		private readonly LoggerInterface $logger,
+		private readonly ICrypto $crypto,
 	) {
 		parent::__construct($request, $config, $l10n);
 
 		$this->id4me = new Service($clientHelper);
 	}
 
 	#[PublicPage]
 	#[NoCSRFRequired]
 	#[UseSession]
 	public function showLogin() {
 		if (!$this->id4MeService->getID4ME()) {
 			$message = $this->l10n->t('ID4Me is disabled');
 			return $this->build403TemplateResponse($message, Http::STATUS_FORBIDDEN, [], false);
 		}
 
@@ -97,22 +97,21 @@
 	}
 
 	/**
-	 * @param string $domain
 	 * @return RedirectResponse|TemplateResponse
 	 */
 	#[PublicPage]
 	#[UseSession]
 	#[BruteForceProtection(action: 'userOidcId4MeLogin')]
 	public function login(string $domain) {
 		if (!$this->id4MeService->getID4ME()) {
 			$message = $this->l10n->t('ID4Me is disabled');
 			return $this->build403TemplateResponse($message, Http::STATUS_FORBIDDEN, [], false);
 		}
 
 		try {
 			$authorityName = $this->id4me->discover($domain);
 		} catch (InvalidOpenIdDomainException|OpenIdDnsRecordNotFoundException $e) {
 			$message = $this->l10n->t('Invalid OpenID domain');
 			return $this->buildErrorTemplateResponse($message, Http::STATUS_BAD_REQUEST, ['invalid_openid_domain' => $domain]);
 		}
 		try {
@@ -166,9 +165,6 @@
 	}
 
 	/**
-	 * @param string $state
-	 * @param string $code
-	 * @param string $scope
 	 * @return JSONResponse|RedirectResponse|TemplateResponse
 	 * @throws \Exception
 	 */