fix(tests): dynamically find SMS gateway index in configure test #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was hardcoding '0' as the gateway selection index, which assumed SMS would always be the first gateway. However, gateways are discovered from the autoloader classmap and may be in different order (e.g., 'gowhatsapp' alphabetically comes before 'sms'). This fix dynamically finds the actual index of the SMS gateway in the available gateways list and uses that for the test input, ensuring the correct gateway is selected before configuring SMS providers. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Collaborator
Author
|
/backport to stable32 |
Collaborator
Author
|
/backport to stable31 |
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.