chore(split): SourceView from ViewerComponent #8037
Conversation
max-nextcloud
force-pushed
the
chore/split-source-view
branch
from
8d2577a to
0b8c9b5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
chore/split-source-view
branch
from
0b8c9b5 to
e169a03
Compare
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks for the refactoring! Out of curiosity, why did you do it? Is it part of a bigger plan? Or just something that caught your eye and cried for a component split? 😊
Code changes look good to me. I didn't test but guess you did. I have two small comments/questions.
| resolve(reader.result) | ||
| } | ||
| }) | ||
| this.onLoaded() |
There was a problem hiding this comment.
It seems new that toggleEdit() now calls this.onLoaded() which emits update.loaded. Was this change in behaviour intended?
| ) | ||
| }, | ||
| /** @return {boolean} */ |
There was a problem hiding this comment.
The annotation already existed before the refactoring, but the return value of readerComponent seems to be rather a Vue component and not a boolean a boolean, right? Maybe a good opportunity to fix (or remove?) the annotation?
No description provided.