Skip to content

Conversation

@jaylinski
Copy link
Member

@jaylinski jaylinski commented Jan 17, 2025

When running npm run build the size of /js/store-C4tptVlq.chunk.mjs will shrink by 0.28 kB (gzip).

The npm ci command is now about 0.5 to 1.0 seconds faster.
The npm install command now installs 990 dependencies instead of 993.

@jaylinski jaylinski marked this pull request as draft January 17, 2025 22:52
"bugs": "https://github.com/nextcloud/tasks/issues",
"contributors": [],
"dependencies": {
"@nextcloud/auth": "^2.4.0",
Copy link
Member Author

@jaylinski jaylinski Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a direct dependency of @nextcloud/axios but not used directly in the code (via import).

"color-convert": "^2.0.1",
"debounce": "^2.2.0",
"ical.js": "^2.1.0",
"linkify-it": "^5.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a direct dependency of markdown-it.

@github-actions
Copy link

github-actions bot commented Feb 1, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@jaylinski jaylinski force-pushed the chore/remove-unused-npm-deps branch 2 times, most recently from af6544d to ca29a87 Compare February 1, 2025 19:13
@jaylinski jaylinski marked this pull request as ready for review February 1, 2025 19:17
Signed-off-by: Jakob Linskeseder <jakob@linskeseder.com>
@jaylinski jaylinski force-pushed the chore/remove-unused-npm-deps branch from ca29a87 to c728161 Compare April 15, 2025 20:52
@raimund-schluessler raimund-schluessler merged commit f0d1c47 into master Apr 28, 2025
28 of 29 checks passed
@raimund-schluessler raimund-schluessler deleted the chore/remove-unused-npm-deps branch April 28, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants