Skip to content

fix: Expire background update of rooms #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SystemKeeper wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Expire background update of rooms #2333

SystemKeeper wants to merge 1 commit into from

Conversation

@SystemKeeper
Copy link
Collaborator

@SystemKeeper SystemKeeper commented Jan 4, 2026

  • Currently we do update and delete in 2 separate transactions -> do it in one, I don't see a reason to have two here.
  • If the background job expired, rollback the transaction and stop the execution

@SystemKeeper
fix: Expire background update of rooms
7b04c71 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper requested a review from Ivansss January 4, 2026 11:11
@SystemKeeper
Copy link
Collaborator Author

SystemKeeper commented Jan 4, 2026

It was a single transcation before 9112c0e#diff-eba5e69a1812d1585a2db89ef47e4a8f93434c27a992790126e164b7e36aa170. I don't see why we shouldn't do it in one?

@SystemKeeper
Copy link
Collaborator Author

SystemKeeper commented Jan 4, 2026

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ivansss Ivansss Awaiting requested review from Ivansss

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

backport-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SystemKeeper