WIP analyze why emoji is not sent as styled emoji #5632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is something wrong with sending the Emoji Variation Selector. I debugged and saw that there are differences between web and android: from web: emoji ❤️ code U+2764 code U+FE0F from Android: emoji ❤ code U+2764 So this is about Emoji Variation Selector (VS-16). The emojis that are send from android are not styled (they do not include the Emoji Variation Selector). If i append FE0F to the classic emojis, it is fixed. But it seems the challenge is to decide when to append the Emoji Variation Selector. i quickly tried to append the style if there is not already one while sending. Works for classic emojis to append the style but other styled emojis are duplicated... pausing for now due to other important things.. Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5632.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5626 (for now it's just some debugging to analyze it)
Have to pause it due to more important things..
🏁 Checklist
/backport to stable-xx.x