Skip to content

fix nfc #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mahibi merged 2 commits into from
Dec 18, 2025
Merged

fix nfc #5589

mahibi merged 2 commits into from
Dec 18, 2025

Conversation

@sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Nov 26, 2025

fix #5303

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch force-pushed the bugfix/5303/fixNFC branch 3 times, most recently from 8e892b2 to 0f47746 Compare November 26, 2025 18:07
@sowjanyakch sowjanyakch marked this pull request as draft November 26, 2025 18:08
@sowjanyakch sowjanyakch changed the title Bugfix/5303/fix nfc fix nfc Nov 26, 2025
@sowjanyakch sowjanyakch marked this pull request as ready for review December 2, 2025 09:04
@mahibi
Copy link
Collaborator

mahibi commented Dec 2, 2025

related:

@mahibi mahibi mentioned this pull request Dec 2, 2025
Closed
@sowjanyakch sowjanyakch marked this pull request as draft December 8, 2025 14:59
@sowjanyakch sowjanyakch marked this pull request as ready for review December 16, 2025 17:26
@sowjanyakch sowjanyakch self-assigned this Dec 16, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Dec 16, 2025
@sowjanyakch @mahibi
fix vibration
13f4517 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
exclude browser login activity from security key listener
9241d2f 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@mahibi mahibi force-pushed the bugfix/5303/fixNFC branch from 4b3f652 to 9241d2f Compare December 18, 2025 12:41
@mahibi mahibi disabled auto-merge December 18, 2025 12:54
@mahibi mahibi merged commit d38f926 into master Dec 18, 2025
14 of 16 checks passed
@mahibi mahibi deleted the bugfix/5303/fixNFC branch December 18, 2025 12:54
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5589.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@mahibi mahibi mentioned this pull request Dec 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NFC / Vibration at every tap in the screen

3 participants

@sowjanyakch @mahibi