revert: timezone conversion intended for meta fields, accidentally broke datetime columns#2583
Open
samuelx12 wants to merge 3 commits intonextcloud:mainfrom
Open
revert: timezone conversion intended for meta fields, accidentally broke datetime columns#2583samuelx12 wants to merge 3 commits intonextcloud:mainfrom
samuelx12 wants to merge 3 commits intonextcloud:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR #2210 (commits 6936f84, 78f8131) and PR #2573 (commit 172a97b).
The change in #2210 was intended to fix UTC display of meta fields (createdAt/lastEditAt), but accidentally applied UTC conversion to all user-facing datetime columns. This causes time values to shift on every save and misinterprets all existing data for users outside UTC.
PR #2573 patches one symptom of the same root cause and is therefore included in this revert.
For the full analysis, see: #2479 (comment)
The original meta field display issue that #2210 was trying to fix still exists and should be addressed separately.
Fixes #2479