Skip to content

Fix: Properly handle an exception threw by find method #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Koc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Properly handle an exception threw by find method #2241

Koc wants to merge 1 commit into from

Conversation

@Koc
Copy link
Contributor

@Koc Koc commented Dec 28, 2025 •
edited
Loading

ColumnMapper::find() not returns null but can throw an DoesNotExistException. Let's adjust code to properly handle this scenario.

To be consistent with addSortQueryForMultipleSleeveFinder or other methods.

@Koc Koc requested review from blizzz and enjeck as code owners December 28, 2025 14:20
@juliusknorr juliusknorr added the bug Something isn't working label Dec 30, 2025
@Koc @juliusknorr
Fix: Properly handle an exception threw by find method
79f5f08 
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@juliusknorr juliusknorr force-pushed the bugfix/fix-catch-exception-from-find branch from 2e1a61c to 79f5f08 Compare December 30, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@enjeck enjeck Awaiting requested review from enjeck enjeck is a code owner

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Koc @juliusknorr