[stable31] fix(signaling): allow SIP bridge to access getSettings without a user session#18116
Open
backportbot[bot] wants to merge 1 commit into
Open
[stable31] fix(signaling): allow SIP bridge to access getSettings without a user session#18116backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
backportbot
Bot
added
bug
regression
feature: api 🛠️
miaulalala
force-pushed
the
backport/18115/stable31
branch
from
d580ba4 to
c125b8b
Compare
… session The security fix in #17576 tightened unauthenticated access to getSettings(), breaking SIP bridge connections. The SIP bridge is a headless service with no userId that authenticates via HMAC headers (Talk-SIPBridge-Random / Talk-SIPBridge-Checksum), which getSettings() was never taught to recognise. Mirror the existing recording-backend detection block: validate the SIP bridge headers when present, return 401 + brute-force throttle on failure, and allow the no-token neutral-point path when the request is authenticated. AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
backport/18115/stable31
branch
from
c125b8b to
598e7a7
Compare
miaulalala
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #18115
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.