Skip to content

fix(LeftSidebar): fix misbehaving mention button#18036

Open
DorraJaouad wants to merge 1 commit into
mainfrom
fix/18035/mention-button-ls
Open

fix(LeftSidebar): fix misbehaving mention button#18036
DorraJaouad wants to merge 1 commit into
mainfrom
fix/18035/mention-button-ls

Conversation

@DorraJaouad
Copy link
Copy Markdown
Contributor

☑️ Resolves

Before, the last layer was filtering. Now the last layer is sorting, which should be used in calculating the mentions and other visual validation.

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy
Copy link
Copy Markdown
Contributor

Antreesy commented May 20, 2026

getFirstItemInViewportIndex, getLastItemInViewportIndex, getItemOffset are not taking into account ConversationTagHeader items: they are rendered and taking height, but not considered when you counting unreadMentionIndices. That's why scroll to bottom, and computing when to show a button has slightly offset with tags used.

Otherwise logic seems good

Comment thread src/components/LeftSidebar/LeftSidebar.vue Outdated
Comment thread src/components/LeftSidebar/LeftSidebar.vue Outdated
Comment thread src/components/LeftSidebar/LeftSidebar.vue Outdated
Comment thread src/components/LeftSidebar/LeftSidebar.vue
Comment thread src/components/LeftSidebar/LeftSidebar.vue Outdated
@DorraJaouad
Copy link
Copy Markdown
Contributor Author

getFirstItemInViewportIndex, getLastItemInViewportIndex, getItemOffset are not taking into account ConversationTagHeader items: they are rendered and taking height, but not considered when you counting unreadMentionIndices. That's why scroll to bottom, and computing when to show a button has slightly offset with tags used.

Otherwise logic seems good

Will be done in a follow up

@Antreesy
Copy link
Copy Markdown
Contributor

Antreesy commented May 22, 2026

Seeing this while trying to click 'Unread mentions', otherwise OK

image

UPD: scroll handling is already covered by @scroll="debounceHandleScroll"

Comment thread src/components/LeftSidebar/LeftSidebar.vue Outdated
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 'Unread mentions' button misbehaves with conversation tags listing

2 participants