Skip to content

fix: restructure Talk integrations#17940

Open
Antreesy wants to merge 1 commit into
mainfrom
fix/noid/integrations-structure
Open

fix: restructure Talk integrations#17940
Antreesy wants to merge 1 commit into
mainfrom
fix/noid/integrations-structure

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy commented May 8, 2026

☑️ Resolves

  • Organize integration files a bit to clean up root/src folder

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (only validated)

File Restructuring: Before → After

Before After
src/main.js src/main.js (unchanged)
src/App.vue src/App.vue (unchanged)
src/mainAdminSettings.js src/mainAdminSettings.js (unchanged)
src/icons.css src/icons.css (unchanged)
src/views/AdminSettings.vue src/AdminSettingsApp.vue
src/init.js src/utils/init.js
src/mainRecording.js src/integrations/recording.js
src/RecordingApp.vue src/integrations/Recording/RecordingApp.vue
src/collections.js src/integrations/collections.js
src/deck.js src/integrations/deck.js
src/flow.js src/integrations/flow.js
src/maps.js src/integrations/maps.js
src/search.js src/integrations/search.js
src/mainFilesSidebarLoader.js src/integrations/filesSidebarLoader.js
src/mainFilesSidebar.js src/integrations/FilesSidebar/filesSidebar.js
src/FilesSidebarLoaderApp.vue src/integrations/FilesSidebar/FilesSidebarLoaderApp.vue
src/FilesSidebarTabApp.vue src/integrations/FilesSidebar/FilesSidebarTabApp.vue
src/views/FilesSidebarCallView.vue src/integrations/FilesSidebar/FilesSidebarCallView.vue
src/views/FilesSidebarChatView.vue src/integrations/FilesSidebar/FilesSidebarChatView.vue
src/mainFloatingCallTrigger.ts src/integrations/floatingCallLoader.ts
src/mainFloatingCall.ts src/integrations/FloatingCall/floatingCall.ts
src/FloatingCallOverlay.vue src/integrations/FloatingCall/FloatingCallOverlay.vue
src/views/FlowPostToConversation.vue src/integrations/WorkflowEngine/FlowPostToConversation.vue
src/mainPublicShareAuthSidebar.js src/integrations/filesPublicShareAuthSidebar.js
src/mainPublicShareSidebar.js src/integrations/filesPublicShareSidebar.js
src/PublicShareAuthRequestPasswordButton.vue src/integrations/FilesPublicShare/FilesPublicShareAuthRequestPasswordButton.vue
src/PublicShareAuthSidebar.vue src/integrations/FilesPublicShare/FilesPublicShareAuthSidebar.vue
src/PublicShareSidebar.vue src/integrations/FilesPublicShare/FilesPublicShareSidebar.vue
src/PublicShareSidebarTrigger.vue src/integrations/FilesPublicShare/FilesPublicShareSidebarTrigger.vue
src/publicShareAuthForm.ts src/integrations/talkPasswordProtectedAuthForm.ts
src/PublicShareAuthForm.vue src/integrations/TalkPasswordProtected/TalkPasswordProtectedAuthForm.vue
BeforeAfter
src/
├── App.vue
├── AdminSettingsApp.vue
├── RecordingApp.vue
├── icons.css
├── init.js
├── main.js
├── mainAdminSettings.js
├── mainRecording.js
├── mainFilesSidebar.js
├── mainFilesSidebarLoader.js
├── mainFloatingCallTrigger.ts
├── mainFloatingCall.ts
├── mainPublicShareAuthSidebar.js
├── mainPublicShareSidebar.js
├── maps.js
├── collections.js
├── deck.js
├── flow.js
├── search.js
├── publicShareAuthForm.ts
├── FilesSidebarLoaderApp.vue
├── FilesSidebarTabApp.vue
├── FloatingCallOverlay.vue
├── PublicShareAuthForm.vue
├── PublicShareAuthRequestPasswordButton.vue
├── PublicShareAuthSidebar.vue
├── PublicShareSidebar.vue
├── PublicShareSidebarTrigger.vue
├── views/
│   ├── AdminSettings.vue
│   ├── FilesSidebarCallView.vue
│   ├── FilesSidebarChatView.vue
│   └── FlowPostToConversation.vue
└── ...
src/
├── App.vue
├── AdminSettingsApp.vue
├── icons.css
├── main.js
├── mainAdminSettings.js
├── assets/
│   └── (other styles)
├── integrations/
│   ├── collections.js
│   ├── deck.js
│   ├── flow.js
│   ├── maps.js
│   ├── search.js
│   ├── recording.js
│   ├── filesSidebarLoader.js
│   ├── floatingCallLoader.ts
│   ├── filesPublicShareAuthSidebar.js
│   ├── filesPublicShareSidebar.js
│   ├── talkPasswordProtectedAuthForm.ts
│   ├── FilesPublicShare/
│   │   ├── FilesPublicShareAuthRequestPasswordButton.vue
│   │   ├── FilesPublicShareAuthSidebar.vue
│   │   ├── FilesPublicShareSidebar.vue
│   │   └── FilesPublicShareSidebarTrigger.vue
│   ├── FilesSidebar/
│   │   ├── filesSidebar.js
│   │   ├── FilesSidebarLoaderApp.vue
│   │   ├── FilesSidebarTabApp.vue
│   │   ├── FilesSidebarCallView.vue
│   │   └── FilesSidebarChatView.vue
│   ├── FloatingCall/
│   │   ├── floatingCall.ts
│   │   └── FloatingCallOverlay.vue
│   ├── Recording/
│   │   └── RecordingApp.vue
│   ├── TalkPasswordProtected/
│   │   └── TalkPasswordProtectedAuthForm.vue
│   └── WorkflowEngine/
│       └── FlowPostToConversation.vue
└── utils/
    ├── init.js
    └── ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🏖️ Next Beta (34) milestone May 8, 2026
@Antreesy Antreesy requested review from DorraJaouad and ShGKme May 8, 2026 14:38
@Antreesy Antreesy self-assigned this May 8, 2026
@Antreesy Antreesy force-pushed the fix/noid/integrations-structure branch from 7dd54f1 to c462af1 Compare May 8, 2026 14:45
@Antreesy Antreesy changed the title fix: remove style loading for Talk integrations fix: restructure Talk integrations May 8, 2026
@DorraJaouad
Copy link
Copy Markdown
Contributor

Why you didn't place *main.js inside their correspondant folder?

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/integrations-structure branch from c462af1 to 334a3e4 Compare May 8, 2026 15:29
@Antreesy
Copy link
Copy Markdown
Contributor Author

Antreesy commented May 8, 2026

Why you didn't place *main.js inside their correspondant folder?

Correspondent folder only have helper files.
All actual entry-points are kept either at src/ or src/integrations, so rspack.config.js is less affected by renaming, and we have a full review from folder tree still

Copy link
Copy Markdown
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure makes sense IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants