Skip to content

[stable33] fix: reduce GPU consumption of virtual background #17596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Apr 2, 2026
Merged

[stable33] fix: reduce GPU consumption of virtual background #17596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a764d94
fix: move GPU-affecting values to constants
Antreesy Mar 20, 2026
0803805
fix: adjust values to improve GPU-performance
Antreesy Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions src/utils/media/effects/virtual-background/WebGLCompositor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,27 @@
*/
// @flow

/**
* Number of horizontal + vertical blur iterations applied.
* Larger value - stronger blur effect. Low GPU impact.
*/
const DEFAULT_BLUR_PASSES = 3
/**
* Spatial radius of the bilateral filter.
* Larger value - smoother mask over a wider area, softer edges. High GPU impact.
*/
const SIGMA_SPACE = 5
/**
* Range sensitivity of the bilateral filter.
* Larger value: more smoothing across edges. Low GPU impact.
*/
const SIGMA_COLOR = 0.15
/**
* Sampling stride scale for the bilateral kernel.
* Larger value - faster processing, rougher mask refinement. High GPU impact.
*/
const SPARSITY_FACTOR = 1

/**
* WebGL-based compositor for background effects.
* Incorporates joint bilateral filtering and multi-pass blur for improved quality.
Expand Down Expand Up @@ -264,8 +285,6 @@ export default class WebGLCompositor {
this.blitSamplerLoc = null

// --- Default parameters ---
this.sigmaSpace = 10.0
this.sigmaColor = 0.15
this.coverage = [0.45, 0.75]
this.lightWrapping = 0.3
this.progressBarColor = [0, 0.4, 0.62, 1] // Nextcloud default primary color (#00679E)
Expand Down Expand Up @@ -468,11 +487,10 @@ export default class WebGLCompositor {
// Calculate filter parameters
const texelWidth = 1 / width
const texelHeight = 1 / height
const kSparsityFactor = 0.66
const step = Math.max(1, Math.sqrt(this.sigmaSpace) * kSparsityFactor)
const radius = this.sigmaSpace
const step = Math.max(1, Math.sqrt(SIGMA_SPACE) * SPARSITY_FACTOR)
const radius = SIGMA_SPACE
const offset = step > 1 ? step * 0.5 : 0
const sigmaTexel = Math.max(texelWidth, texelHeight) * this.sigmaSpace
const sigmaTexel = Math.max(texelWidth, texelHeight) * SIGMA_SPACE

// Set uniforms
gl.uniform1i(gl.getUniformLocation(this.progBilateral, 'u_inputFrame'), 0)
Expand All @@ -482,7 +500,7 @@ export default class WebGLCompositor {
gl.uniform1f(gl.getUniformLocation(this.progBilateral, 'u_radius'), radius)
gl.uniform1f(gl.getUniformLocation(this.progBilateral, 'u_offset'), offset)
gl.uniform1f(gl.getUniformLocation(this.progBilateral, 'u_sigmaTexel'), sigmaTexel)
gl.uniform1f(gl.getUniformLocation(this.progBilateral, 'u_sigmaColor'), this.sigmaColor)
gl.uniform1f(gl.getUniformLocation(this.progBilateral, 'u_sigmaColor'), SIGMA_COLOR)

// Bind textures
gl.activeTexture(gl.TEXTURE0)
Expand Down Expand Up @@ -532,8 +550,7 @@ export default class WebGLCompositor {
gl.activeTexture(gl.TEXTURE1)
gl.bindTexture(gl.TEXTURE_2D, this.texMaskFiltered)

// Apply 3 blur passes
for (let i = 0; i < 3; i++) {
for (let i = 0; i < DEFAULT_BLUR_PASSES; i++) {
// Horizontal pass
gl.uniform2f(gl.getUniformLocation(this.progBlur, 'u_texelSize'), 0, texelHeight)
gl.bindFramebuffer(gl.FRAMEBUFFER, this.fboBlur1)
Expand Down
Loading