Skip to content

Fix error when creating mail shares if custom tokens are enabled #60378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danxuliu wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix error when creating mail shares if custom tokens are enabled #60378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8f9162
fix: Fix error when creating mail shares if custom tokens are enabled
danxuliu May 14, 2026
3a5f3ff
chore(assets): Recompile assets
nextcloud-command May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,6 +1131,9 @@ export default {

// ugly hack to make code work - we need the id to be set but at the same time we need to keep values we want to update
this.share._share.id = share.id
// Similarly the token is always set by the backend when the
// share is created.
this.share._share.token = share.token
await this.queueUpdate(...permissionsAndAttributes)
// Also a ugly hack to update the updated permissions
for (const prop of permissionsAndAttributes) {
Expand Down
2 changes: 1 addition & 1 deletion build/eslint-baseline-legacy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"apps/files_sharing/src/views/SharingDetailsTab.vue": {
"vue/no-mutating-props": {
"count": 23
"count": 24
}
},
"apps/files_sharing/src/views/SharingLinkList.vue": {
Expand Down
4 changes: 2 additions & 2 deletions dist/5638-5638.js → dist/3577-3577.js
View file
Open in desktop

Large diffs are not rendered by default.

0 dist/5638-5638.js.license → dist/3577-3577.js.license
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions dist/3577-3577.js.map
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions dist/3577-3577.js.map.license
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3577-3577.js.license
1 change: 0 additions & 1 deletion dist/5638-5638.js.map
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dist/5638-5638.js.map.license
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading