fix(dav): apply client-provided mtime before cache update#58983
Draft
joshtrichards wants to merge 1 commit intomasterfrom
Draft
fix(dav): apply client-provided mtime before cache update#58983joshtrichards wants to merge 1 commit intomasterfrom
joshtrichards wants to merge 1 commit intomasterfrom
Conversation
The x-oc-mtime header was applied after the cache updater scanned the file, meaning the scanner would briefly write the current time() to the cache before it was corrected. This created a small window where the wrong mtime was visible, and triggered a redundant cache write. Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a sync client uploads a file with an
x-oc-mtime header, the provided mtime is applied after$storage->getUpdater()->update()runs. The scanner insideupdate()reads the filesystem mtime viastat(), which at that point reflects the current server time -- not the client-provided value. This means the cache is briefly populated with the wrong mtime beforeView::touch()corrects it.Additionally,
View::touch()goes throughbasicOperation, which can triggerwriteUpdate()hooks/updater side effects depending on the view's state -- an unnecessary risk given the DAV code already manages the updater manually.Changes introduced by this PR:
$storage->touch($internalPath, $mtime)before the updater, so the scanner sees the correct mtime from the filesystem.mtimedirectly to the filecache viaputFileInfo.upload_time,mtime(fallback), andcreation_timeinto a singleputFileInfocall.View::touch()call entirely.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)