fix(initializeSession): only log HMAC problem to critical logs if indeed critical#58975
Open
fix(initializeSession): only log HMAC problem to critical logs if indeed critical#58975
Conversation
…eed critical Signed-off-by: Simon L. <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/42157/hid-warning
branch
from
a4031be to
b0bcd1f
Compare
szaimen
added
3. to review
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
szaimen
requested review from
Altahrim,
ArtificialOwl,
ChristophWurst,
come-nc,
icewind1991 and
miaulalala
and removed request for
a team
come-nc
requested changes
Mar 17, 2026
| } | ||
| return $this->decryptWithoutSecret($authenticatedCiphertext, $password); | ||
| } catch (Exception $e) { | ||
| } catch (\RuntimeException|Exception $e) { |
Contributor
There was a problem hiding this comment.
Suggested change
| } catch (\RuntimeException|Exception $e) { | |
| } catch (Exception $e) { |
RuntimeException extends Exception already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.