fix: manually set modified time to SFTP files after editing#58970
Draft
fix: manually set modified time to SFTP files after editing#58970
Conversation
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes SFTP file writes. When uploading a file to the SFTP server, the files original modified date is not preserved. The SFTP server typically sets the modified date to the time of upload. This leads to issues, for example, with Nextcloud Office, which expects the mtime to match the mtime of the file. Nextcloud office then repeatedly throws errors indicating that the file has been modified externally. In this PR the SFTP implementation explicitely sets the modified date of the file.
Checklist
3. to review, feature component)stable32)AI (if applicable)