Skip to content

refactor(View): clearer control flow and stronger edge-case handling for getFileInfo#58955

Draft
joshtrichards wants to merge 9 commits intomasterfrom
jtr/refactor-View-getFileInfo
Draft

refactor(View): clearer control flow and stronger edge-case handling for getFileInfo#58955
joshtrichards wants to merge 9 commits intomasterfrom
jtr/refactor-View-getFileInfo

Conversation

@joshtrichards
Copy link
Member

  • Resolves: #

Summary

  • Added clearer inline comments and improved method phpdoc (including the partial-file fallback behavior).
  • Flattened control flow with early returns for invalid path, missing mount, and invalid storage.
  • Split path handling into explicit relativePath and fullPath variables for readability.
  • Improved logging context for mount/storage resolution failures.

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…eInfo

Also use explicit path variant variable names rather than mutating and overusing vague $path var.

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 34 milestone Mar 15, 2026
@joshtrichards joshtrichards added feature: filesystem ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: filesystem ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant