(feat) setup appdata folder based on config #57747
Open
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhil1508
requested review from
Altahrim,
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
Signed-off-by: Akhil <akhil@e.email>
akhil1508
force-pushed
the
dev/custom-appdata
branch
from
4bde0d8 to
807619e
Compare
akhil1508
commented
Jan 23, 2026
| @@ -424,10 +424,26 @@ public function setupRoot(): void { | |||
| foreach ($rootMounts as $rootMountProvider) { | |||
| $this->mountManager->addMount($rootMountProvider); | |||
| } | |||
|
|
|||
| $this->setupAppData(); | |||
Contributor
Author
There was a problem hiding this comment.
I don't know if this is the right place to do this mount setup. setupRoot doesn't have any events to hook into either.
But if we do it in AppData.php like in #36337, occ files:scan-app-data stops working since that command does a tearDownFS and setupFS.
Whereas $setupManager->setupRoot() seems to me is completed generally for all requests, commands and background jobs.
Please suggest a better approach if possible :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
appdata_[instanceid]folder #36337TODO
Checklist
3. to review, feature component)stable32)