Skip to content

Share mount validation fixes #57745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
icewind1991 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Share mount validation fixes #57745

icewind1991 wants to merge 3 commits into from
+54 −13

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jan 22, 2026 •
edited
Loading

  • For transfered shares we might need to re-perform share target validation.
  • The "only refresh shares once per user per request" optimization seems to be overeager, breaks some cases and needs to be reworked.

@icewind1991 icewind1991 added this to the Nextcloud 34 milestone Jan 22, 2026
@icewind1991 icewind1991 requested a review from a team as a code owner January 22, 2026 18:16
@icewind1991 icewind1991 removed the request for review from a team January 22, 2026 18:16
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 22, 2026
@icewind1991 icewind1991 changed the title feat: add event for tranfered shares Share mount validation fixes Jan 22, 2026
@icewind1991 icewind1991 mentioned this pull request Jan 22, 2026
Draft
4 tasks
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Jan 22, 2026
@nickvergessen
test: Run tests against nextcloud/server#57745 "Share mount validatio…
9067690 
…n fixes"

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Jan 22, 2026
Open
@icewind1991
feat: add event for tranfered shares
d42fe8d 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: remove validate-user-shares-once optimization
858b058 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the share-transfered-event branch from b3fc17e to 858b058 Compare January 22, 2026 19:31
@artonge artonge mentioned this pull request Jan 23, 2026
Open
@icewind1991
fix: prevent recursion in SharesUpdatedListener
48a23fe 
Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

2 participants

@icewind1991