Skip to content

Fix incorrect user count #57736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sebastianmueller22 wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −0
Open

Fix incorrect user count #57736

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f750022
fix: user count
Sebastianmueller22 Jan 22, 2026
623d620
fix: typo in comment
Sebastianmueller22 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/settings/lib/Controller/UsersController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,11 @@ public function usersList(INavigationManager $navigationManager, ISubAdmin $subA
/** Using LDAP or admins (system config) can enfore sorting by group name, in this case the frontend setting is overwritten */
$forceSortGroupByName = $sortGroupsBy === MetaData::SORT_GROUPNAME;


// display user count with a plus appended, if limit is exceeded
$userCount = ($userCount < self::COUNT_LIMIT_FOR_SUBADMINS) ? $userCount : self::COUNT_LIMIT_FOR_SUBADMINS . '+';
Copy link
Member

@CarlSchwan CarlSchwan Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change the return type in the frontend, not sure what are the consequence of that

Copy link
Author

@Sebastianmueller22 Sebastianmueller22 Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't produce any issue in my test. I looked for usages and it seems to be handled in a type agnostic way. I did it in oder to not have the limit hard coded in the frontend as well.

I could alternatively send the limit with the response and make the check in the frontend. Should I do that instead?



/* FINAL DATA */
$serverData = [];
// groups
Expand Down