Digital Signature: Hide digital signature inputs from user settings #5233
+0
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Collabora Online already supports digital signatures via the settings iframe, this patch is intended to only hide the UI inputs. The related variables will still be sent to Online through checkfileinfo, and migration cases will be handled as well. Online PR: CollaboraOnline/online#12913 Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Member
|
Since which version does Collabora show this in the settings iframe? Should we only hide it in case we know this is present? |
juliusknorr
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Digital Signature: Hide digital signature inputs from user settings
Since Collabora Online already supports digital signatures via the settings iframe, this patch is intended to only hide the UI inputs. The related variables will still be sent to Online through checkfileinfo, and migration cases will be handled as well.
Online PR: CollaboraOnline/online#12913