fix(openapi): Don't mark unknown default values as required #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
I'm not sure if this is a good idea. Having the parameter marked as required, has the benefit, that consumers need to think about what they want. If it's not required but also has no default value, then it's easier to forget about the parameter.
I'm fine with merging, however it could lead to confusion in the opposite direction.
Member
Author
… has the problem that typescript generated from it does not allow submitting the request without specifying the value in your client side code, which basically makes the idea of having a server defined default which we can change with an update not possible 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #284