Skip to content

fix: Sharing on older NC versions with files v3 #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enjeck wants to merge 2 commits into
base: v5.0
Choose a base branch
from
Open

fix: Sharing on older NC versions with files v3 #1853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac5a6e5
fix: Sharing on older NC versions with files v3
enjeck May 9, 2026
1ab39a5
fix: Limit NC versions
enjeck May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ The Notes app is a distraction free notes taking app for [Nextcloud](https://www
<screenshot small-thumbnail="https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Notes/notes-thumbnail.jpg">https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Notes/notes.png</screenshot>
<dependencies>
<php min-version="8.1" max-version="8.5"/>
<nextcloud min-version="30" max-version="34"/>
<nextcloud min-version="30" max-version="32"/>
</dependencies>
<repair-steps>
<post-migration>
Expand Down
2 changes: 1 addition & 1 deletion playwright/e2e/basic.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ test.describe('Basic checks', () => {
await noteItem.locator('.action-item__menutoggle').click()
await page.getByRole('menuitem', { name: 'Share', exact: true }).click()

await expect(page.locator('[data-cy-notes-share-sidebar]')).toBeVisible({ timeout: 15000 })
await expect(page.locator('[data-cy-sidebar]')).toBeVisible({ timeout: 15000 })
await expect(page.getByText('Internal shares')).toBeVisible({ timeout: 15000 })
})
})
3 changes: 0 additions & 3 deletions src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
</div>
</NcAppContent>
<router-view v-else @note-deleted="onNoteDeleted" />
<NoteShareSidebar />
</NcContent>
</template>

Expand All @@ -62,7 +61,6 @@ import FolderPlusIcon from 'vue-material-design-icons/FolderPlus.vue'
import AppSettings from './components/AppSettings.vue'
import CategoriesList from './components/CategoriesList.vue'
import EditorHint from './components/Modal/EditorHint.vue'
import NoteShareSidebar from './components/NoteShareSidebar.vue'

import { config } from './config.js'
import { fetchNotes, noteExists, undoDeleteNote } from './NotesService.js'
Expand All @@ -82,7 +80,6 @@ export default {
NcAppNavigationNew,
NcAppNavigationItem,
NcContent,
NoteShareSidebar,
FolderPlusIcon,
},

Expand Down
40 changes: 0 additions & 40 deletions src/WebdavService.js
View file
Open in desktop

This file was deleted.

10 changes: 8 additions & 2 deletions src/components/NoteItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,8 +307,14 @@ export default {
}
},
onToggleSharing() {
this.actionsOpen = false
emit('notes:share:open', { noteId: this.note.id })
if (window?.OCA?.Files?.Sidebar?.setActiveTab) {
emit('toggle-navigation', { open: false })
setTimeout(() => {
window.dispatchEvent(new Event('resize'))
}, 200)
window.OCA.Files.Sidebar.setActiveTab('sharing')
window.OCA.Files.Sidebar.open(this.note.internalPath)
}
},
async onShareCreated(event) {
const { share } = event
Expand Down
265 changes: 0 additions & 265 deletions src/components/NoteShareSidebar.vue
View file
Open in desktop

This file was deleted.

Loading