Conversation
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Explore feed URL handling to support language-aware custom Explore services while keeping the built-in Explore service on a stable English endpoint, and adjusts related test coverage.
Changes:
- Frontend: fetch Explore recommendations from either a custom base URL (language-aware with fallback) or a provided default base URL (English).
- Backend: provide both
exploreUrl(custom, trimmed) anddefaultExploreUrl(generated from the internal Explore route) via initial state. - Tests: extend unit tests to cover custom/default URL selection and fallback behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/components/routes/Explore.vue |
Implements custom-vs-default Explore URL selection plus language-aware custom fetching with English fallback. |
lib/Controller/PageController.php |
Adds defaultExploreUrl to initial state and stops substituting the default into exploreUrl. |
tests/javascript/unit/components/routes/Explore.spec.ts |
Adds unit tests validating URL construction and fallback logic. |
docker/Dockerfile |
Updates the Nextcloud Docker base image from 30-apache to 33-apache. |
You can also share your feedback on Copilot code review. Take the survey.
Grotax
changed the title
wofferl
approved these changes
Mar 13, 2026
SMillerDev
reviewed
Mar 14, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Wolfgang <github@linux-dude.de> Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax
added a commit
that referenced
this pull request
Mar 17, 2026
Changed
- Re-implement custom explore source function, admins can configure a custom url where the app will search for feeds.{$langcode}.json (#3609)
- Implement the cron check as a setup check, Admins need to check. (#2831)
- DEV: update to phpunit 10 (#3616)
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Mar 17, 2026
Changed
- Re-implement custom explore source function, admins can configure a custom url where the app will search for feeds.{$langcode}.json (#3609)
- Implement the cron check as a setup check, Admins need to check. (#2831)
- DEV: update to phpunit 10 (#3616)
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax
added a commit
that referenced
this pull request
Mar 17, 2026
Changed
- Re-implement custom explore source function, admins can configure a custom url where the app will search for feeds.{$langcode}.json (#3609)
- Implement the cron check as a setup check, Admins need to check. (#2831)
- DEV: update to phpunit 10 (#3616)
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new frontend is hard coded to always look for
feeds.en.json.This change re-implements the function that an admin can set a custom url.
The frontend will check for the users language specific json e.g.
feeds.de.jsonand if not found fall back to English.Checklist