chore: update to vuejs3 and nc34#1527
Open
TheoLallement wants to merge 10 commits intonextcloud:masterfrom
Open
chore: update to vuejs3 and nc34#1527TheoLallement wants to merge 10 commits intonextcloud:masterfrom
TheoLallement wants to merge 10 commits intonextcloud:masterfrom
Conversation
Signed-off-by: Théo Lallement <lallement.theo@gmail.com>
Signed-off-by: Théo Lallement <lallement.theo@gmail.com>
Signed-off-by: Théo Lallement <lallement.theo@gmail.com>
Signed-off-by: Théo Lallement <lallement.theo@gmail.com>
Signed-off-by: Théo Lallement <lallement.theo@gmail.com>
Signed-off-by: Théo Lallement <lallement.theo@gmail.com>
Signed-off-by: Théo Lallement <lallement.theo@gmail.com>
Signed-off-by: Théo Lallement <lallement.theo@gmail.com>
Signed-off-by: Théo Lallement <lallement.theo@gmail.com>
ee7b2f6 to
1dd48da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
First contribution for me so sorry in adance if i didn't do everything right.
There is a lot of non regression to do but I don't know all the features of the app so it's kinda hard to test this.
Main changes
Update of Vue.Js parts of code to be compatible with new Nextcloud versions.
Migrating to vue 3
this.$set(array, index, newValue)bythis.array[key] = newValuecreateAppinstead ofVuevue-click-outsidepackage and make custom directiveslot="customSlot"to#slotMigrating to new nextcloud api (v9.x.x to have vue3 compat)
window.OCA.Files.Sidebar.setActiveTaband replaced it by aactiveTabpropsimport { NcActionButton } from '@nextcloud/vue'instead ofimport NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton.js'isMobilebyuseIsMobile(deleted in v9.x.x)NcCounterBubbleinside<template #counter>and use the:countpropsReplace
vue2-lealfetbyleafletHardest part to explain and document. WIP
Todo
in another pr maybe to not make this one bigger than it already is