fix(ui): sub-mailbox drops blocked by parent cascade#12964
Open
ChristophWurst wants to merge 1 commit into
Open
fix(ui): sub-mailbox drops blocked by parent cascade#12964ChristophWurst wants to merge 1 commit into
ChristophWurst wants to merge 1 commit into
Conversation
Two bugs in the droppable-mailbox directive:
1. [droppable-mailbox="disabled"] applied pointer-events:none and opacity:.3
to the whole element, cascading into sub-mailboxes rendered in the slot
and making them unreachable as drop targets.
2. With pointer-events:none unscoped, drag events reached the wrapper div of
disabled mailboxes; onDragLeave unconditionally called setStatus('enabled'),
visually re-enabling them mid-drag.
Scope the disabled styling to > div > a (matching the dragover state) and
add canBeDropped() guards to onDragOver/onDragLeave/onDrop.
Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
Member
Author
|
/backport to stable5.8 |
Member
Author
|
/backport to stable5.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the droppable-mailbox directive:
[droppable-mailbox="disabled"] applied pointer-events:none and opacity:.3 to the whole element, cascading into sub-mailboxes rendered in the slot and making them unreachable as drop targets.
With pointer-events:none unscoped, drag events reached the wrapper div of disabled mailboxes; onDragLeave unconditionally called setStatus('enabled'), visually re-enabling them mid-drag.
Scope the disabled styling to > div > a (matching the dragover state) and add canBeDropped() guards to onDragOver/onDragLeave/onDrop.
Partly introduced by #12650. cc @cdvv7788
How to test
main: they are disabled
here: they are enabled
Assisted-by: Claude:claude-sonnet-4-6