fix: disable CSRF check for message-id deeplinks#12959
Open
SoleroTG wants to merge 1 commit into
Open
Conversation
Signed-off-by: SoleroTG <github-29h@solero.quietmail.eu>
|
Thanks for opening your first pull request in this repository! ✌️ |
Member
FTFY |
ChristophWurst
approved these changes
May 21, 2026
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Thanks for the fix
CSRF can be skipped for a GET 👍
Member
|
/backport to stable5.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a CSRF error that occurs when accessing a message-id deeplink directly via the browser's address bar or via external apps. This feature was recently introduced in #12632 .
Since the route is accessed via a standard, stateless
GETrequest from outside the Vue frontend, no CSRF token header is present. Adding the#[NoCSRFRequired]attribute to theDeepLinkController::openmethod allows the stateless redirect to work as intended.Related Issue
Follow-up fix for #12632.
How to test
https://<your-nc>/apps/mail/open/<valid-message-id>