fix(smime): surface unparseable stored certificates instead of crashing#12956
Open
ChristophWurst wants to merge 1 commit into
Open
fix(smime): surface unparseable stored certificates instead of crashing#12956ChristophWurst wants to merge 1 commit into
ChristophWurst wants to merge 1 commit into
Conversation
PageController and SmimeCertificatesController called enrichCertificate() for all stored S/MIME certificates without catching SmimeCertificateParserException. One unparseable certificate (e.g. a TLS certificate accidentally imported before stricter email validation was added in b3d7c9a) would crash the entire page load or the certificate list API call. Catch the exception in both controllers and return an error-state EnrichedSmimeCertificate (info: null, error: message) so the certificate still appears in the management UI and can be deleted by the user. Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
ChristophWurst
added
bug
3. to review
feature:smime
Member
Author
|
/backport to stable5.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PageController and SmimeCertificatesController called enrichCertificate() for all stored S/MIME certificates without catching SmimeCertificateParserException. One unparseable certificate (e.g. a TLS certificate accidentally imported before stricter email validation was added in b3d7c9a) would crash the entire page load or the certificate list API call.
Catch the exception in both controllers and return an error-state EnrichedSmimeCertificate (info: null, error: message) so the certificate still appears in the management UI and can be deleted by the user.
Assisted-by: Claude:claude-sonnet-4-6
Tested with a bogus cert smuggled into the db. Error is reproducible on main and not here. Cert correctly listed as invalid:
Fixes #12954