Skip to content

fix(package): exclude dev config and patch files from release tarball#12955

Merged
kesselb merged 1 commit into
mainfrom
fix/nextcloudignore-dev-files
May 21, 2026
Merged

fix(package): exclude dev config and patch files from release tarball#12955
kesselb merged 1 commit into
mainfrom
fix/nextcloudignore-dev-files

Conversation

@ChristophWurst
Copy link
Copy Markdown
Member

@ChristophWurst ChristophWurst commented May 20, 2026

eslint.config.mjs (flat config), stylelint.config.js, playwright.config.js, tsconfig.json, .patches/, patches.json, and patches.lock.json were all missing from .nextcloudignore and ended up in the v5.8.0 release tarball.

Assisted-by: Claude:claude-sonnet-4-6

Summary by CodeRabbit

  • Chores
    • Updated synchronization configuration to exclude additional development and configuration files.

Review Change Stack

eslint.config.mjs (flat config), stylelint.config.js, playwright.config.js,
tsconfig.json, .patches/, patches.json, and patches.lock.json were all
missing from .nextcloudignore and ended up in the v5.8.0 release tarball.

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
@ChristophWurst
Copy link
Copy Markdown
Member Author

/backport to stable5,8

@ChristophWurst
Copy link
Copy Markdown
Member Author

/backport to stable5.8

@ChristophWurst
Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e0ba90e-ac57-4dcc-9cad-faf44a8fe590

📥 Commits

Reviewing files that changed from the base of the PR and between 34d8036 and 6d20e3f.

📒 Files selected for processing (1)
  • .nextcloudignore

📝 Walkthrough

Walkthrough

The PR updates .nextcloudignore to exclude additional development and build tooling files from Nextcloud synchronization. It adds entries for ESLint configuration, patch management files, and standard tool configs like Playwright, Stylelint, and TypeScript configuration.

Changes

Development tooling ignore patterns

Layer / File(s) Summary
Extend ignore patterns for tooling config and patch files
.nextcloudignore
Added /eslint.config.mjs at line 14 and extended the ignore list with /patches, /patches.json, /patches.lock.json, /playwright.config.js, /stylelint.config.js, and /tsconfig.json to prevent development artifacts from being synced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit's whisper in the code so bright,
Files tucked away from Nextcloud's sight,
Config and patches, now neatly concealed,
Development secrets, forever sealed! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: excluding development configuration and patch files from the release tarball via .nextcloudignore updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/nextcloudignore-dev-files

Comment @coderabbitai help to get the list of available commands and usage tips.

@kesselb kesselb merged commit b1bc155 into main May 21, 2026
46 checks passed
@kesselb kesselb deleted the fix/nextcloudignore-dev-files branch May 21, 2026 22:23
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

2 participants