Open
Conversation
Signed-off-by: Cristian <cristianvargasvalencia@gmail.com>
Signed-off-by: Cristian <cristianvargasvalencia@gmail.com>
cdvv7788
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MoveModal reappearing after bulk move (#12661)
The MoveModal was nested inside the v-if="selectMode" div. During a bulk move, envelopes are removed from the store, which empties the selection, which flips selectMode to false — destroying the MoveModal before it can emit @close. The showMoveModal flag stays true, so the modal reappears on the next selection. Fixed by moving the MoveModal component to the root level of the template (matching how TagModal is already placed), so its lifecycle depends only on its own v-if="showMoveModal".
Missing "important" icon in multi-select quick actions (#12149)
The template used
<ImportantIcon>but the component was never imported or registered. Added the missing import of LabelVariant.vue and registered it in the components block.