fix(ui): add ckeditor body element to editor focus trap #12182
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
bug
3. to review
regression
feature:editor
Member
Author
|
/backport to stable5.6 |
kesselb
reviewed
Dec 18, 2025
| }, | ||
| onEditorReady({ additionalFocusTrap }) { | ||
| if (additionalFocusTrap && this.additionalTrapElements.indexOf() === -1) { |
Contributor
There was a problem hiding this comment.
indexOf without an argument? 🤔
Member
Author
There was a problem hiding this comment.
I even tested it 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12178
additionalTrapElementsdata (regression of fix(NewMessageModal): remove null focus trap selectors #12118)This makes it possible to inserts links with CKEditor again, while also avoiding the focus trap issues on mobile.
How to test link insertion
main: you can't focus link text or URL
here: you can focus the inputs and type a value
How to test mobile editing
main: multiselect opens and closes instantly. You can't enter anything
here: multiselect opens and you can enter a value