feat(macOS): Add trash sync toggle for FileProvider virtual files #9264
+392
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flo-129
requested review from
Aiiaiiio,
camilasan,
i2h3,
mgallien and
nilsding
as code owners
Flo-129
force-pushed
the
feature/macos-fileprovider-trash-sync
branch
2 times, most recently
from
e7f29e2 to
2f103a7
Compare
Add user-facing option to control NSFileProviderDomain.supportsSyncingTrash property (macOS 13.0+). When enabled, deleted files appear in macOS Trash and server trash contents are visible in Finder. When disabled, Finder shows "Delete Immediately" option. Changes: - Add "Integrate macOS Trash" checkbox in FileProvider settings - Store per-account trash sync preference in NSUserDefaults - Implement domain reconfiguration (remove/add cycle) when setting changes - Add thread-safety with QMutex for domain registry access - Clean up unused socket-based communication code (replaced by XPC) Signed-off-by: Flo-129 <Flo-129@users.noreply.github.com>
Flo-129
force-pushed
the
feature/macos-fileprovider-trash-sync
branch
from
2f103a7 to
7eba65a
Compare
This was referenced Dec 17, 2025
Collaborator
|
Thank you for your new pull request! I will bring this up for discussion internally. 🤔 Personally, I think it is fine to have a checkbox for that feature toggle but it contradicts our design guidelines on the other hand. 😵💫 I need to check in with the others. |
|
Could ya'll approve workflows so we can test the builds from CI? |
|
Artifact containing the AppImage: nextcloud-appimage-pr-9264.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan
Requirements