feat: Add option to disable CloudProviders sidebar integration #9233

eriolloan · 2025-12-11T18:03:45Z

Summary

Adds a new user setting to optionally disable CloudProviders D-Bus integration on Linux, allowing users to hide synchronized folders from the file manager sidebar while keeping sync functionality intact.

Changes

Adds checkbox in Settings → General: "Show synchronized folders in file manager sidebar"
Default: enabled (maintains current behavior)
When disabled: CloudProviders integration is not initialized
Linux-only feature (CloudProviders is Linux-specific via libcloudproviders)

Implementation details

New config setting: showCloudProvidersInFileManager (defaults to true)
UI checkbox only visible on Linux builds (#ifndef Q_OS_LINUX)
Early return in CloudProviderManager constructor when disabled
Requires application restart to take effect (CloudProviders initialized at startup)

Testing

Checkbox appears in General Settings (Linux only)
Default is enabled
Disabling + restart removes folders from Nautilus sidebar
Re-enabling + restart restores folders
Sync functionality works in both states

Screenshot

Related issues

Fixes #1982

Adds a new setting in General preferences to control whether synchronized folders appear in the file manager sidebar via CloudProviders on Linux. Changes: - Add 'showCloudProvidersInFileManager' config setting (defaults to true) - Add checkbox in General Settings UI (Linux only) - Check setting during CloudProviderManager initialization - Skip DBus registration when disabled The setting requires application restart to take effect. Signed-off-by: eriolloan <15250783+eriolloan@users.noreply.github.com>

camilasan · 2025-12-15T16:08:35Z

src/gui/cloudproviders/cloudprovidermanager.cpp

+    OCC::ConfigFile cfg;
+    if (!cfg.showCloudProvidersInFileManager()) {
+        qCInfo(lcNextcloudCloudProviderIntegration) << "CloudProviders disabled by user setting";
+        return;
+    }
+


I think it makes more sense to move this logic to application.cpp, do the check before calling ownCloudGui::setupCloudProviders:

desktop/src/gui/application.cpp

Line 408 in a514416

_gui->setupCloudProviders();

camilasan · 2025-12-15T16:19:49Z

src/gui/generalsettings.cpp

+void GeneralSettings::slotToggleCloudProviders(bool checked)
+{
+    ConfigFile cfgFile;
+    cfgFile.setShowCloudProvidersInFileManager(checked);


beyond changing the config file, you need to call here ownCloudGui::setupCloudProviders (I could be wrong, maybe another function), so the change will take effect without restarting the client.

Thanks I'll look into it tomorrow

Moves the setting check from CloudProviderManager constructor to Application startup, following the suggestion to check before calling setupCloudProviders rather than inside the manager itself. This keeps the initialization logic cleaner and more consistent with how other optional components are handled. Signed-off-by: eriolloan <15250783+eriolloan@users.noreply.github.com>

eriolloan · 2025-12-15T17:45:54Z

Thanks for the review! I've moved the check to application.cpp.

Regarding making the toggle take effect without restart - I looked into this and ran into a few complications. Tell me if I'm mistaken but it looks like :

setupCloudProviders() creates the manager with new CloudProviderManager(this) but doesn't store the pointer anywhere
To dynamically enable/disable, we'd need to store _cloudProviderManager in ownCloudGui and implement a cleanup method
More importantly, the manager registers with DBus (g_bus_own_name) during construction, and I'm not sure if simply destroying the object would properly unregister from DBus or if we'd need explicit cleanup

Is keeping the restart requirement acceptable for now? The tooltip does mention it's needed.
But i can look into what modifications would be needed.

camilasan · 2025-12-16T11:11:20Z

Thanks for the review! I've moved the check to application.cpp.

Thanks for the PR.

We discussed your changes in the team and I am afraid I didn't realize the implications of your changes when I first reviewed it.

So we would like to propose the following:

remove the UI option: we think this new setting is very niche, most people will still use the default to enable the cloud providers. Keep it only in the config file.
- for this I would suggest to also update the documentation so people will know it exists.

Regarding making the toggle take effect without restart - I looked into this and ran into a few complications. Tell me if I'm mistaken but it looks like :

setupCloudProviders() creates the manager with new CloudProviderManager(this) but doesn't store the pointer anywhere

I think you can leave this as it is now.

To dynamically enable/disable, we'd need to store _cloudProviderManager in ownCloudGui and implement a cleanup method

More importantly, the manager registers with DBus (g_bus_own_name) during construction, and I'm not sure if simply destroying the object would properly unregister from DBus or if we'd need explicit cleanup

Given that now it would require to change the config file by hand, then items 2 and 3 are not a concern anymore.

I hope this proposal is OK with you :)

eriolloan · 2025-12-18T12:36:26Z

Thanks for discussing this with the team! I'm happy to make the changes you suggest.

Before I do though, I'd like to share some context on why I thought a UI option would be valuable:

The problem affects several user groups:

Users with multiple sync folders - the sidebar gets cluttered with many items, pushing devices and network mounts and other bookmarks down in Nautilus (sometimes requiring scrolling)
Users who already bookmarked their folders - CloudProviders creates duplicates of folders they manually added to bookmarks
Users on immutable distributions (like Fedora Silverblue/Kinoite, NixOS, etc.) - they can't easily edit the .desktop file workaround that some users recommend (example)
Non-technical users - editing config files isn't intuitive for everyone

There are existing reports of this issue: issue #3361 (from 2021, still open) and I found myself in a combination of some of these situations, prompting the PR.

That said, I fully understand the concern about UI clutter for a niche feature.
Si if you prefer to keep it config-only with some documentation, I'm totally fine with that! Just wanted to make sure the use cases were clear. Let me know what you'd like me to do and I'll update the PR accordingly.

github-actions · 2025-12-26T02:17:18Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

eriolloan requested review from Aiiaiiio, camilasan, i2h3, mgallien and nilsding as code owners December 11, 2025 18:03

eriolloan force-pushed the feature/optional-cloudproviders-sidebar branch from 3d821a7 to cc8a441 Compare December 11, 2025 18:40

camilasan requested changes Dec 15, 2025

View reviewed changes

camilasan reviewed Dec 15, 2025

View reviewed changes

i2h3 added the os: 🐧 Linux label Dec 17, 2025

github-actions bot added the feedback-requested label Dec 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add option to disable CloudProviders sidebar integration #9233

feat: Add option to disable CloudProviders sidebar integration #9233

Uh oh!

eriolloan commented Dec 11, 2025 •

edited

Loading

Uh oh!

camilasan Dec 15, 2025

Uh oh!

camilasan Dec 15, 2025 •

edited

Loading

Uh oh!

eriolloan Dec 15, 2025

Uh oh!

eriolloan commented Dec 15, 2025

Uh oh!

camilasan commented Dec 16, 2025 •

edited

Loading

Uh oh!

eriolloan commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: Add option to disable CloudProviders sidebar integration #9233

Are you sure you want to change the base?

feat: Add option to disable CloudProviders sidebar integration #9233

Uh oh!

Conversation

eriolloan commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Implementation details

Testing

Screenshot

Related issues

Uh oh!

camilasan Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

camilasan Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eriolloan Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

eriolloan commented Dec 15, 2025

Uh oh!

camilasan commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eriolloan commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eriolloan commented Dec 11, 2025 •

edited

Loading

camilasan Dec 15, 2025 •

edited

Loading

camilasan commented Dec 16, 2025 •

edited

Loading