Skip to content

Conversation

@findlayfeng
Copy link

Now, it attempts to load all values ​​returned by the function QLocale::system().uiLanguages() sequentially until success or all values ​​fail, instead of only trying the first value.

#8092

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the inline comments

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the compilation errors on Linux
you can have a look at https://github.com/nextcloud/desktop/actions/runs/19921541571/job/57111130337?pr=9108

auto-merge was automatically disabled December 6, 2025 01:58

Head branch was pushed to by a user without write access

@findlayfeng
Copy link
Author

@mgallien
Can this patch be applied? The user's client version has been stuck on version 3.13.3 for too long.

Now, it attempts to load all values ​​returned by the
function QLocale::system().uiLanguages() sequentially
until success or all values ​​fail, instead of only trying
the first value.

Signed-off-by: Findlay Feng <i@fengch.me>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, it seems to work fine from my end (tested this by changing the LANGUAGE env var to e.g. zh_CN or de_AT)

@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-9108.zip

Digest: sha256:5215b9f8df431d3ecc5fb85e04c9c06b758f48f13c0a6d90fad790070ca92c55

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants