WIP: declarative UI. #8401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

camilasan wants to merge 25 commits into master from feature/declarative-ui

Member

camilasan commented Jun 25, 2025 •

edited

Loading

Implements nextcloud/files-clients#86

dialog

screencasts
- accessing it from systray activities list:
  https://github.com/user-attachments/assets/9bf65691-374a-4567-ab49-ae207a2f2a31
- accessing it from the context menu:
  https://github.com/user-attachments/assets/f38e38e2-431d-4641-b066-ec3e563efe67
to do
- get designer's input
- filter by mime type
  - there are some glitches
- test with files explorer/finder context menu
- do not show file actions when there are none
- better error handling
- better error message and UI for it
- fix url parsing for analytics

sonarqubecloud bot commented Jun 25, 2025

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)
55 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Member

nilsding commented Jul 1, 2025

looking good so far

one nit for the current app-menu-submenu-WIP: Apps that provide custom actions should be indicated as such -- this could be done by e.g. appending … at the end of the name, or adding another arrow button similar to how it's done in the accounts drop down

camilasan force-pushed the feature/declarative-ui branch from 8f783b2 to 330facf Compare

September 3, 2025 19:31

Rello added this to 💻 Desktop Clients team

Rello moved this to 🏗️ In progress in 💻 Desktop Clients team

camilasan changed the title ~~wip: declarative UI.~~ feat: declarative UI.

camilasan force-pushed the feature/declarative-ui branch from 533a29d to 31f81d6 Compare

September 18, 2025 00:10


          feat(socketapi): add file actions option to list of options for files.

6a4887b

Signed-off-by: Camila Ayres <hello@camilasan.com>

camilasan force-pushed the feature/declarative-ui branch 2 times, most recently from 8eefb0d to 6e31576 Compare

October 1, 2025 14:18

camilasan added 9 commits

October 1, 2025 16:22


          feat(declarativeui): add basic class to retrieve json from server.

0857e65

- add endpoints model.
- add class to manage endpoints and declarativeui display.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          feat(declarativeui): fetch delcarativeui endpoints in capabilities.

749acb5

Signed-off-by: Camila Ayres <hello@camilasan.com>


          feat(declarativeui): display application window with declarative ui.

fcbdc77

- display endpoints in an application window.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          feat(declarativeui): list declarative ui and file actions in context …

d9aa794

…menu.

- remove EndpointModel from DeclarativeUi class.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          feat(declarativeui): list declarative ui and file actions in the tray…

61d9a00

… activitiy.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          fix(declarativeui): remove log messages.

cdfdec4

Signed-off-by: Camila Ayres <hello@camilasan.com>


          feat(declarativeui): add icon and filter to endpoint model and UI.

9254b31

- add one action to the endpoints.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          feat: style file actions window.

61a0255

Signed-off-by: Camila Ayres <hello@camilasan.com>


          feat: display response from request from file actions.

84182cd

Signed-off-by: Camila Ayres <hello@camilasan.com>

camilasan force-pushed the feature/declarative-ui branch from 6e31576 to e94e635 Compare

October 1, 2025 14:25

camilasan added 10 commits

October 1, 2025 16:27


          feat(declarativeui): improve the looks of the file actions Window.

b0144ae

Signed-off-by: Camila Ayres <hello@camilasan.com>


          fix: context menu.

ef47072

Signed-off-by: Camila Ayres <hello@camilasan.com>


          fix: update datat parsing to new API format.

a412e37

Signed-off-by: Camila Ayres <hello@camilasan.com>


          feat: add helper function to match string to SimpleApiJob::Verb.

2fcd450

- use the file id in file actions requests.
- filter and display file actions based on the file mimetype.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          fix: handle file action response.

f9ba223

- adjust logic to get context menu by mimeType.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          refactor: create function to set file id and mime type.

68fdd15

- remove unused functions.
- save string values in constexpr
- rename Endpoint to Fileactions.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          feat: add logging category to FileActionsModel.

89617e4

Signed-off-by: Camila Ayres <hello@camilasan.com>


          refactor: improve error handling.

c34e6b5

- change icon for file.
- display a different icon for each mimetype.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          feat: return default icon when server doesn't have one.

a51c1b3

- improve file actions window UI.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          fix: parse response with declarative UI elements like url.

cda47d5

- add opacity mask and more spacing.
- Implement hover for the file action buttons.
- fix logic to display error/success messages.
- improve text for error/success messages.

Signed-off-by: Camila Ayres <hello@camilasan.com>


          refactor: remove unused DeclarativeUi class.

7bb54ab

The declarative ui in fact will be returned in the response from file actions.

Signed-off-by: Camila Ayres <hello@camilasan.com>

camilasan force-pushed the feature/declarative-ui branch 2 times, most recently from 01de4be to 27ac3c1 Compare

October 1, 2025 14:36


          fix: files license.

a998866

Signed-off-by: Camila Ayres <hello@camilasan.com>

camilasan force-pushed the feature/declarative-ui branch from 27ac3c1 to a998866 Compare

October 1, 2025 15:15

camilasan added 3 commits

October 1, 2025 17:23


          refactor: remove Declarative UI menu item.

d35122d

Signed-off-by: Camila Ayres <hello@camilasan.com>


          fix: use reference type in for loop.

aa96145

Signed-off-by: Camila Ayres <hello@camilasan.com>


          fix: spaces and sizes in the file actions window.

4a95c2c

Signed-off-by: Camila Ayres <hello@camilasan.com>

camilasan force-pushed the feature/declarative-ui branch from fb77cbc to 4a95c2c Compare

October 1, 2025 17:29

github-actions bot commented Oct 1, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8401.zip

Digest: sha256:fd28cac59b8cadb82b13a5a7911a859eb47c09b5cafb1350a132ad9567fc67e3

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

sonarqubecloud bot commented Oct 1, 2025

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
108 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Rello moved this from 🏗️ In progress to 📄 To do in 💻 Desktop Clients team

camilasan changed the title ~~feat: declarative UI.~~ WIP: declarative UI.

Rello moved this from 📄 To do to 🏗️ In progress in 💻 Desktop Clients team

Rello assigned camilasan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio will be requested when the pull request is marked ready for review Aiiaiiio is a code owner

i2h3 Awaiting requested review from i2h3 i2h3 will be requested when the pull request is marked ready for review i2h3 is a code owner

mgallien Awaiting requested review from mgallien mgallien will be requested when the pull request is marked ready for review mgallien is a code owner

nilsding Awaiting requested review from nilsding nilsding will be requested when the pull request is marked ready for review nilsding is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet