Skip to content

feat: add support for multimodal indexing#227

Open
kyteinsky wants to merge 6 commits intomainfrom
feat/noid/ocr-support
Open

feat: add support for multimodal indexing#227
kyteinsky wants to merge 6 commits intomainfrom
feat/noid/ocr-support

Conversation

@kyteinsky
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Comment thread appinfo/info.xml Outdated
}

protected function configure() {
$this->setName('context_chat:queue-multimodal-files')
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, after the update, the admin has to run this command to queue multimodal files?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, but only for the existing files, the new files and updated files would be auto queued, if the corresponding task types are present.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be expected that all admins want this? Then, we could make it a migration, perhaps

Copy link
Copy Markdown
Contributor Author

@kyteinsky kyteinsky Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, yeah it would make sense to do that since we already do all the files and would be doing all the newly detected multimodal files too.
maybe it would become necessary to also implement this then: #195

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the ignore path is not there yet and probably won't be in the next release, it would be better to not queue all the images and audio for indexing automatically but only the new ones IMO since there might be a lot of them and with the command there would still be a choice.
wdyt?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a weird mechanism. Either the admin wants all multimodal files indexed or none. If the issue is that the a migration would just add all files without asking the admin, we should have multimodal indexing off by default. And have a switch in the context chat settings that turns it on for all files.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that works too, setting and a command to do that.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no command

Copy link
Copy Markdown
Contributor Author

@kyteinsky kyteinsky Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not? It would just be a caller of a service like the UI.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought you meant, admins would have to enable the setting and call the command. If it's an or then I'm ok with it :)

Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
@kyteinsky kyteinsky force-pushed the feat/reverse-content-flow branch from 524c8c0 to 9ea6f62 Compare April 14, 2026 12:33
Base automatically changed from feat/reverse-content-flow to main April 23, 2026 08:11
@kyteinsky kyteinsky force-pushed the feat/noid/ocr-support branch from cb519c3 to 126c2d8 Compare May 2, 2026 10:30
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants