Conversation
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
| } | ||
|
|
||
| protected function configure() { | ||
| $this->setName('context_chat:queue-multimodal-files') |
There was a problem hiding this comment.
So, after the update, the admin has to run this command to queue multimodal files?
There was a problem hiding this comment.
yep, but only for the existing files, the new files and updated files would be auto queued, if the corresponding task types are present.
There was a problem hiding this comment.
Would it be expected that all admins want this? Then, we could make it a migration, perhaps
There was a problem hiding this comment.
hmm, yeah it would make sense to do that since we already do all the files and would be doing all the newly detected multimodal files too.
maybe it would become necessary to also implement this then: #195
There was a problem hiding this comment.
since the ignore path is not there yet and probably won't be in the next release, it would be better to not queue all the images and audio for indexing automatically but only the new ones IMO since there might be a lot of them and with the command there would still be a choice.
wdyt?
There was a problem hiding this comment.
I think it's a weird mechanism. Either the admin wants all multimodal files indexed or none. If the issue is that the a migration would just add all files without asking the admin, we should have multimodal indexing off by default. And have a switch in the context chat settings that turns it on for all files.
There was a problem hiding this comment.
yeah that works too, setting and a command to do that.
There was a problem hiding this comment.
why not? It would just be a caller of a service like the UI.
There was a problem hiding this comment.
Ah, I thought you meant, admins would have to enable the setting and call the command. If it's an or then I'm ok with it :)
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
524c8c0 to
9ea6f62
Compare
…ation" This reverts commit 7f69a72.
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
cb519c3 to
126c2d8
Compare
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
No description provided.